Welcome, Guest
Username: Password: Remember me

TOPIC:

The Responsive JEM 4 years 7 months ago #24768

What is a contrution? I don't get it.

In Egnart's override [mytemplate]/html/com_jem/event/default.php I propose to replace the lines in the venue section, starting at line 271
<?php
          if (!empty($this->item->venueslug)) :
            echo '<a href="' . JRoute::_(JemHelperRoute::getVenueRoute($this->item->venueslug)) . '">' . $this->escape($this->item->venue) . '</a>';
          else :
            echo $this->escape($this->item->venue);
          endif;
          if (!empty($this->item->url)) :
            echo '&nbsp;-&nbsp;<a target="_blank" href="' . $this->item->url . '">' . JText::_('COM_JEM_WEBSITE') . '</a>';
          endif;
          ?>

by these lines, following the settings made in event detail page > venue > link to venue:

<?php if (($params->get('event_show_detlinkvenue') == 1) && (!empty($this->item->url))) : ?>
            <a target="_blank" href="<?php echo $this->item->url; ?>"><?php echo $this->escape($this->item->venue); ?></a>
			<?php elseif (($params->get('event_show_detlinkvenue') == 2) && (!empty($this->item->venueslug))) : ?>
            <a href="<?php echo JRoute::_(JemHelperRoute::getVenueRoute($this->item->venueslug)); ?>"><?php echo $this->item->venue; ?></a>
          <?php else/*if ($params->get('event_show_detlinkvenue') == 0)*/ :
            echo $this->escape($this->item->venue);
          endif; ?>

So there too, you either show no link, a link to the venue's url or a link to a list of events at that venue. Just the same as on top of the script.
Regards,
Herbert
The topic has been locked.

The Responsive JEM 4 years 7 months ago #24779

  • Egnarts
  • Egnarts's Avatar Topic Author
  • Offline
  • Elite Member
  • Elite Member
  • Posts: 288
  • Thank you received: 124
Thank you HerKle for your feedback.
I integrated the hint with the venue link into the next release of JEM-Responsive.
I am currently working and thinking about your change of the attachments. Yes you are right about the icons. They don't fit into the new layout. But for each file a "File:" at the beginning of the line is not the best... Eventually I or you find another "Word" for that.
The topic has been locked.

The Responsive JEM 4 years 7 months ago #24780

Hi Egnarts,

ah, I see. I seldomly have more than one attachment for an event. But in the case of multiple files, you could
  • either tell the loop to echo "Files" only once in the first row
  • or use the file title as label

Btw: I observed strange behavior when the label name is longer than the foreseen width: Instead of hyphenating the expression and use a second line, the term is cut and an ellipse (…) added. Why is that?
Regards,
Herbert
Last edit: by HerKle.
The topic has been locked.

The Responsive JEM 4 years 7 months ago #24781

Hi Egnarts,

your responsive JEM adds a second icon font (FontAwesome) – which is not needed if you use IcoMoon which is already delivered by Joomla core. Just a thought to save loading ressources…
Regards,
Herbert
The topic has been locked.

The Responsive JEM 4 years 7 months ago #24785

  • Egnarts
  • Egnarts's Avatar Topic Author
  • Offline
  • Elite Member
  • Elite Member
  • Posts: 288
  • Thank you received: 124
The string is cut because the newline (word-break) did not work for me in some tests and some browsers as I can remember.

About IcoMoon - I never heard about that. I have to examine this option.Thank you for the hint.
The topic has been locked.

The Responsive JEM 4 years 7 months ago #24786

I use
-ms-hyphens: auto;
-webkit-hyphens: auto;
hyphens: auto;

rather than word-break. The proprietary hyphens before the standard cover older browsers.

In this example I added it to the class sectiontableheader to achieve hyphenating when all the columns in the eventtable are activated:

Regards,
Herbert
Attachments:
The topic has been locked.
Time to create page: 0.607 seconds

Donate

If you find JEM useful and if you use it on your site, please consider a donation to the project.

Private Messages

You are not logged in.

Follow us......