Welcome, Guest
Username: Password: Remember me
Feature requests for JEM 2.0 - initial public release
  • Page:
  • 1

TOPIC: No more style in output.class.php, please! (Google Map)

No more style in output.class.php, please! (Google Map) 3 years 5 months ago #22781

  • HerKle
  • HerKle's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Style is poor man's basic right
  • Posts: 157
  • Thank you received: 27
Searching for solutions to a problem, I discovered my own ancient posts…– again!
So I moved this to feature request in hope that this will be noticed finally by someone responsible for coding.
My suggestion for future releases is not to use style attributes in files, which cannot be altered by overrides, eg. output.class.php:

I propose to replace the code in line 753 , now 815 (which shows that something happened to it in v2.0.0 )
<div style="border: 1px solid #000;width:500px;"><iframe width="500" height="250"  … />
by
<div class="googlemap"><iframe class="iframe_googlemap" … />
so that you can define these classes by css.

I made these changes once and hoped that the last JEM update didn't override them – but it did. Since it was so long ago, I didn't remember the core file hack. So, I had to spend hours for finding out why to hell the google map design had altered – and normally you search for style definitions in files of 'views' directories or css stylesheets, but not in core files.
So, PLEASE, do change this BEFORE the next update!
THANK YOU SO MUCH!
Regards,
Herbert
The following user(s) said Thank You: jojo12

Please Log in or Create an account to join the conversation.

No more style in output.class.php, please! (Google Map) 3 years 5 months ago #22784

  • diesl
  • diesl's Avatar
  • Offline
  • Platinum Boarder
  • Platinum Boarder
  • Posts: 882
  • Karma: 16
  • Thank you received: 69
I currently work on adding Openstreetmap as an alternative map provider to JEM. Along the way I am refactoring the code so I can add it to my to do list ;)
Repository: Github // Issues: Github // Languages: Transifex
The following user(s) said Thank You: HerKle, hekla

Please Log in or Create an account to join the conversation.

No more style in output.class.php, please! (Google Map) 3 years 5 months ago #22786

  • HerKle
  • HerKle's Avatar Topic Author
  • Offline
  • Expert Boarder
  • Expert Boarder
  • Style is poor man's basic right
  • Posts: 157
  • Thank you received: 27
Along the way, wherever you meet some style="" else in core files – make it vanish. :-)
Regards,
Herbert
The following user(s) said Thank You: hekla, Wolfgang

Please Log in or Create an account to join the conversation.

No more style in output.class.php, please! (Google Map) 3 years 5 months ago #22787

  • diesl
  • diesl's Avatar
  • Offline
  • Platinum Boarder
  • Platinum Boarder
  • Posts: 882
  • Karma: 16
  • Thank you received: 69
I got the message :lol:
Repository: Github // Issues: Github // Languages: Transifex

Please Log in or Create an account to join the conversation.

  • Page:
  • 1
Time to create page: 0.228 seconds

Donate

If you find JEM useful and if you use it on your site, please consider a donation to the project.

Private Messages

You are not logged in.

Follow us......